Skip to content

Improving footer translation#1511

Closed
davichaves wants to merge 4 commits into
rubygems:masterfrom
davichaves:improving-footer-translation
Closed

Improving footer translation#1511
davichaves wants to merge 4 commits into
rubygems:masterfrom
davichaves:improving-footer-translation

Conversation

@davichaves
Copy link
Copy Markdown

I improved the translation for the footer and translated it to portuguese. The missing translations for the footer are: de, es, fr, nl, zh-CN, zh-TW. If people could help me by translating to these languages that would be awesome 😄

@sonalkr132
Copy link
Copy Markdown
Member

Hi @davichaves! Thanks for PR 👍

Can you please update nl, zh-CN, zh-TW as well?

@homu
Copy link
Copy Markdown
Contributor

homu commented Jan 8, 2017

☔ The latest upstream changes (presumably #1522) made this pull request unmergeable. Please resolve the merge conflicts.

@arthurnn
Copy link
Copy Markdown
Member

not sure if @davichaves speaks nl, zh-CN, zh-TW to be able to update those files.
If a key is not found in a locale file, rails(i18n) would just fallback to english correct?
If that's the case, I think we can ship this and let native speakers translate the other versions.

@sonalkr132
Copy link
Copy Markdown
Member

not sure if @davichaves speaks nl, zh-CN, zh-TW to be able to update those files.

I understand 😅
This PR removes footer_about and adds about_p1. We have translation of footer_about in nl, zh-CN, zh-TW, it should be changed to about_p1. Something very similar to e884bbf

@jvanbaarsen
Copy link
Copy Markdown
Contributor

@davichaves Are you still working on this?

@dwradcliffe
Copy link
Copy Markdown
Member

Closing since this is stale and needs to be rebased. Happy to get it merged if you still want to work on it. 😄

@dwradcliffe dwradcliffe closed this May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants