Skip to content

fix permalink: /specification-refence → /specification-reference#206

Merged
hsbt merged 1 commit into
rubygems:gh-pagesfrom
chocolateboy:fix-permalink
Mar 7, 2018
Merged

fix permalink: /specification-refence → /specification-reference#206
hsbt merged 1 commit into
rubygems:gh-pagesfrom
chocolateboy:fix-permalink

Conversation

@chocolateboy
Copy link
Copy Markdown
Contributor

currently the typo link works and the correct link 404s e.g.:

see #205

@bundlerbot
Copy link
Copy Markdown

☔ The latest upstream changes (presumably #207) made this pull request unmergeable. Please resolve the merge conflicts.

@colby-swandale
Copy link
Copy Markdown
Member

Thanks for the PR. I'm cautious to accept this PR as this would break the URLs that are indexed on Google. We should try to make the page accessible via /specification-refence and also /specification-reference

@olleolleolle
Copy link
Copy Markdown
Member

@chocolateboy I wonder - for me, currently, the first link is OK and the second link is 404.

Does this change things about this PR?

@chocolateboy
Copy link
Copy Markdown
Contributor Author

chocolateboy commented Jan 10, 2018

@olleolleolle The typo's still there. The correct link only started working again (and the incorrect link only stopped working) after #207.

@chocolateboy
Copy link
Copy Markdown
Contributor Author

Incidentally, #207 says:

PR #201 appears to have broken the links that Google has indexed.

I think the Google indexing thing is a red herring. Google was pointing to /specification-reference when I raised #205, and is still pointing to it now:

Google search for "require_paths"

And I can't find any references to specification-refence in its cache:

Google search for "require_paths"

@hsbt hsbt merged commit 13b9cfe into rubygems:gh-pages Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants