Skip to content

create a CONTRIBUTING.md to explain how to contribute to this repo.#201

Merged
colby-swandale merged 4 commits into
rubygems:gh-pagesfrom
lostapathy:contributing
Jan 8, 2018
Merged

create a CONTRIBUTING.md to explain how to contribute to this repo.#201
colby-swandale merged 4 commits into
rubygems:gh-pagesfrom
lostapathy:contributing

Conversation

@lostapathy
Copy link
Copy Markdown
Contributor

Following up where #195 left off - I'm trying to move the current contributing.md to contributing-to-rubygems.md and then add a more conventional CONTRIBUTING.md that explains how to work on the guides themselves.

Specifically, to document what should be changed directly in this repo and what shouldn't, and point people to the correct location for things edited elsewhere. Hopefully that'll save maintainers some effort.

So far I've found that running rake postrelease on rubygems itself will run this which rebuilds some generated docs and pushes them out to release.

@segiddins (or anyone else) are there any other processes I should be aware of when writing this up?

Comment thread CONTRIBUTING.md
@@ -0,0 +1,6 @@
## How to contribute to guides.rubygems.org
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can put this in .github so we don’t have to rename the existing file?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, and I know you suggested it on the other thread, but I feel like putting it at the root is more of the "standard" so it's more likely to be discovered this way, and if it's more likely to be discovered people are more likely to follow it.

Also on https://github.com/rubygems/guides/community - I believe that page would forever link "Contributing" to the old file, which is not desired behavior.

@lostapathy lostapathy changed the title [WIP] create a CONTRIBUTING.md to explain how to contribute to this repo. create a CONTRIBUTING.md to explain how to contribute to this repo. Jan 6, 2018
@lostapathy
Copy link
Copy Markdown
Contributor Author

This is now ready for review. I'm pretty sure I covered what's needed to at least point people in the right direction. I decided not to get into the details of the mechanics of how these docs are actually generated as it gets fairly involved to explain and most people won't need to know to contribute.

@colby-swandale
Copy link
Copy Markdown
Member

There seems to be 2 changes here, one is adding CONTRIBUTING.md but why are you also changing the metadata as well?

@bundlerbot
Copy link
Copy Markdown

☔ The latest upstream changes (presumably #204) made this pull request unmergeable. Please resolve the merge conflicts.

@lostapathy
Copy link
Copy Markdown
Contributor Author

Good question, I should have explained the change to the front matter.

Per the Jekyll docs, permalink is the correct way to specify the location of the page, not url.

I had to set it to permalink in the page I renamed to contributing-to-rubygems.md to keep it at the current URL. I updated the url param to match on the existing pages to get everything consistent again and hopefully prevent a regression in the future if someone were to "fix" that file by setting it back to url.

Comment thread CONTRIBUTING.md Outdated
@@ -0,0 +1,16 @@
## How to contribute to guides.rubygems.org

#### **If you want to contribute to RubyGems itself, visit [the RubyGems Guides](http://guides.rubygems.org/contributing/)**
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty confusing as to what's happening here, either remove the ** or don't make this a header

Comment thread CONTRIBUTING.md Outdated
#### **If you want to contribute to RubyGems itself, visit [the RubyGems Guides](http://guides.rubygems.org/contributing/)**
This guide just covers the details of contributing to the guides themselves.

### Running guides.rubygems.org
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Setting up a local development environment instead? I find that more clearer.

Comment thread CONTRIBUTING.md Outdated

### Running guides.rubygems.org

The [guides.rubygems.org site](http://guides.rubygems.org) site is built on [Jekyll](https://github.com/jekyll/jekyll). To run the site locally, you'll first need to install Jekyll via `gem install jekyll`. Once installed, you can start the development server via `jekyll server` and point your browser to [http://localhost:4000](http://localhost:4000)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just say The guides are built on.., we don't need to link to the production site again.

Comment thread CONTRIBUTING.md
### Running guides.rubygems.org

The [guides.rubygems.org site](http://guides.rubygems.org) site is built on [Jekyll](https://github.com/jekyll/jekyll). To run the site locally, you'll first need to install Jekyll via `gem install jekyll`. Once installed, you can start the development server via `jekyll server` and point your browser to [http://localhost:4000](http://localhost:4000)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra spacing

@colby-swandale
Copy link
Copy Markdown
Member

I'm happy to merge this once the feedback has been addressed.

@lostapathy
Copy link
Copy Markdown
Contributor Author

Thanks for the review @colby-swandale! I believe I've updated everything as requested.

@colby-swandale
Copy link
Copy Markdown
Member

Thanks!

@colby-swandale
Copy link
Copy Markdown
Member

colby-swandale commented Jan 9, 2018

@lostapathy I've had to unfortunately revert this PR as there were a couple of issues.

All the URLs that Google has indexed where broken due to a difference in how the URI is generated between url: and permalink: in jekyll.

The other issue is that url: contributing doesn't appear to be working either. I get 404 on my machine unless i rename contributing-to-rubygems.md back to contributing.md.

These 2 issues forced me to revert the entire PR instead of just fixing the links.

I would still like to see a contributing doc for the rubygem guides but we will need to find a workaround.

@lostapathy
Copy link
Copy Markdown
Contributor Author

Bummer! And sorry for the hassle @colby-swandale. It'll probably take a couple weeks before I'm free enough to troubleshoot it, but I'll get to the bottom of this and report back with a better-vetted solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants