create a CONTRIBUTING.md to explain how to contribute to this repo.#201
Conversation
| @@ -0,0 +1,6 @@ | |||
| ## How to contribute to guides.rubygems.org | |||
There was a problem hiding this comment.
Maybe we can put this in .github so we don’t have to rename the existing file?
There was a problem hiding this comment.
I thought about that, and I know you suggested it on the other thread, but I feel like putting it at the root is more of the "standard" so it's more likely to be discovered this way, and if it's more likely to be discovered people are more likely to follow it.
Also on https://github.com/rubygems/guides/community - I believe that page would forever link "Contributing" to the old file, which is not desired behavior.
|
This is now ready for review. I'm pretty sure I covered what's needed to at least point people in the right direction. I decided not to get into the details of the mechanics of how these docs are actually generated as it gets fairly involved to explain and most people won't need to know to contribute. |
|
There seems to be 2 changes here, one is adding |
|
☔ The latest upstream changes (presumably #204) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Good question, I should have explained the change to the front matter. Per the Jekyll docs, I had to set it to |
503ca36 to
aa48e34
Compare
| @@ -0,0 +1,16 @@ | |||
| ## How to contribute to guides.rubygems.org | |||
|
|
|||
| #### **If you want to contribute to RubyGems itself, visit [the RubyGems Guides](http://guides.rubygems.org/contributing/)** | |||
There was a problem hiding this comment.
This is pretty confusing as to what's happening here, either remove the ** or don't make this a header
| #### **If you want to contribute to RubyGems itself, visit [the RubyGems Guides](http://guides.rubygems.org/contributing/)** | ||
| This guide just covers the details of contributing to the guides themselves. | ||
|
|
||
| ### Running guides.rubygems.org |
There was a problem hiding this comment.
How about Setting up a local development environment instead? I find that more clearer.
|
|
||
| ### Running guides.rubygems.org | ||
|
|
||
| The [guides.rubygems.org site](http://guides.rubygems.org) site is built on [Jekyll](https://github.com/jekyll/jekyll). To run the site locally, you'll first need to install Jekyll via `gem install jekyll`. Once installed, you can start the development server via `jekyll server` and point your browser to [http://localhost:4000](http://localhost:4000) |
There was a problem hiding this comment.
I would just say The guides are built on.., we don't need to link to the production site again.
| ### Running guides.rubygems.org | ||
|
|
||
| The [guides.rubygems.org site](http://guides.rubygems.org) site is built on [Jekyll](https://github.com/jekyll/jekyll). To run the site locally, you'll first need to install Jekyll via `gem install jekyll`. Once installed, you can start the development server via `jekyll server` and point your browser to [http://localhost:4000](http://localhost:4000) | ||
|
|
|
I'm happy to merge this once the feedback has been addressed. |
aa48e34 to
9ec44d8
Compare
9ec44d8 to
a6794e4
Compare
|
Thanks for the review @colby-swandale! I believe I've updated everything as requested. |
|
Thanks! |
|
@lostapathy I've had to unfortunately revert this PR as there were a couple of issues. All the URLs that Google has indexed where broken due to a difference in how the URI is generated between The other issue is that These 2 issues forced me to revert the entire PR instead of just fixing the links. I would still like to see a contributing doc for the rubygem guides but we will need to find a workaround. |
|
Bummer! And sorry for the hassle @colby-swandale. It'll probably take a couple weeks before I'm free enough to troubleshoot it, but I'll get to the bottom of this and report back with a better-vetted solution. |
Following up where #195 left off - I'm trying to move the current contributing.md to contributing-to-rubygems.md and then add a more conventional CONTRIBUTING.md that explains how to work on the guides themselves.
Specifically, to document what should be changed directly in this repo and what shouldn't, and point people to the correct location for things edited elsewhere. Hopefully that'll save maintainers some effort.
So far I've found that running
rake postreleaseon rubygems itself will run this which rebuilds some generated docs and pushes them out to release.@segiddins (or anyone else) are there any other processes I should be aware of when writing this up?