removing multiline gem specifications correctly

[jethroo]

What was the end-user problem that led to this PR?

This PR fixes the issue #7431 where gems specified in multiple lines were not removed correctly.

What was your diagnosis of the problem?

The remove was implemented in a way that the match was only done for a line each.

What is your fix for the problem, implemented in this PR?

Now upon line removal it is checked if the gem specification was finished in this line. If there is a trailing , comma further lines needs to be removed.

[welcome]

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

[hsbt]

Can you add the extra gems that are the original report?

Like this:

gem 'git'
gem 'some-gem',
    git: 'ssh://gitlab-server.com/project/repo.git',
    branch: 'master'
gem 'nokogiri'

And add expectation for git and nokogiri.

[jethroo]

thanks for the feedback, sure would give more test context, will do soonish ;)

[deivid-rodriguez]

Haven't reviewed this, but I agree with fixing this 👍.

However, this kind of maintenance burden reenforces my position that we should not accept features like #6623 or #6597.