Skip to content

Remove multiline gem specifications correctly#3400

Merged
deivid-rodriguez merged 2 commits intomasterfrom
jethroo-fix/Issue_7431_remove_multi_line_gems_correctly
May 22, 2020
Merged

Remove multiline gem specifications correctly#3400
deivid-rodriguez merged 2 commits intomasterfrom
jethroo-fix/Issue_7431_remove_multi_line_gems_correctly

Conversation

@hsbt
Copy link
Copy Markdown
Member

@hsbt hsbt commented Mar 18, 2020

Description:

Migrated from rubygems/bundler#7454.

Fixes #3306.

Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

deivid-rodriguez and others added 2 commits May 22, 2020 13:19
Co-authored-by: Carsten Wirth <carsten.wirth@homeday.de>
@deivid-rodriguez deivid-rodriguez force-pushed the jethroo-fix/Issue_7431_remove_multi_line_gems_correctly branch from ea2f1b3 to 8dca0ad Compare May 22, 2020 11:20
@deivid-rodriguez deivid-rodriguez changed the title removing multiline gem specifications correctly Remove multiline gem specifications correctly May 22, 2020
Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@deivid-rodriguez deivid-rodriguez merged commit 698367c into master May 22, 2020
@deivid-rodriguez deivid-rodriguez deleted the jethroo-fix/Issue_7431_remove_multi_line_gems_correctly branch May 22, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle remove does not remove multi line gems

4 participants