This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Merged
Conversation
segiddins
force-pushed
the
segiddins/ruby-2.6
branch
from
9fa452f to
4576077
Compare
Contributor
Author
|
Looks like we can no longer use forwardable (it's now a gem), and a spec needs to be updated for bundler being a default gem |
4 tasks
segiddins
force-pushed
the
segiddins/ruby-2.6
branch
from
4576077 to
dcfc275
Compare
added 3 commits
December 28, 2018 21:44
Contributor
Author
|
That last commit doesn’t work, we need to avoid using the shell so we don’t need to shellescape the directory |
Contributor
|
Maybe we can use a manifest file like in rubygems. |
Member
|
i would prefer avoiding that |
Member
|
I've ended up just copying what the |
Contributor
Author
|
👍 |
Member
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Dec 30, 2018
6856: Test against Ruby 2.6 and RubyGems 3 r=colby-swandale a=segiddins ### What was the end-user problem that led to this PR? The problem was we weren't testing our compatibility with the latest and greatest. Co-authored-by: Samuel Giddins <segiddins@segiddins.me> Co-authored-by: Colby Swandale <me@colby.fyi>
Build succeeded |
ghost
merged commit
colby-swandale
pushed a commit
that referenced
this pull request
Dec 30, 2018
6856: Test against Ruby 2.6 and RubyGems 3 r=colby-swandale a=segiddins The problem was we weren't testing our compatibility with the latest and greatest. Co-authored-by: Samuel Giddins <segiddins@segiddins.me> Co-authored-by: Colby Swandale <me@colby.fyi> (cherry picked from commit a63a39d)
colby-swandale
pushed a commit
that referenced
this pull request
Jan 4, 2019
* 2-0-stable: (39 commits) Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 bump bundler_2_mode in inject spec Version 2.0.0.pre.2 with Changelog fix failing major deprecation error spec remove :github source declaration from new gem template ...
colby-swandale
pushed a commit
that referenced
this pull request
Feb 10, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ...
colby-swandale
pushed a commit
that referenced
this pull request
Feb 12, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ...
colby-swandale
pushed a commit
that referenced
this pull request
Feb 18, 2019
* commit '77f4c15451aaac135d19ac5d1637981d7b05d799': (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ...
colby-swandale
pushed a commit
that referenced
this pull request
Feb 20, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Feb 28, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Mar 13, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Mar 13, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Mar 15, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Mar 20, 2019
* 2-0-stable: (43 commits) remove path that i copied from my personal computer Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect Merge #6941 Merge #6834 Version 2.0.1 with changelog update tested rubygems in travis Lower required RubyGems to 2.5 or greater Bundler 2.0 with changelog update CHANGELOG with new changes and release Merge #6856 add RubyGems v3.0.1 to rg clone task Version 2.0.0.pre.3 wih changelog update tested versions of RubyGems in travis update gemspec to require RubyGems 3.0.0 Merge #6849 Merge #6853 Revert "Version 2.0.0 with changelog" Version 2.0.0 with changelog fix breaking edge case spec Merge #6818 ... (cherry picked from commit 77f4c15)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was we weren't testing our compatibility with the latest and greatest.