Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

[SharedHelpers] Only hard-error on major deprecations in the following version#6586

Merged
bundlerbot merged 1 commit intomasterfrom
segiddins/softer-major-deprecations
Jun 21, 2018
Merged

[SharedHelpers] Only hard-error on major deprecations in the following version#6586
bundlerbot merged 1 commit intomasterfrom
segiddins/softer-major-deprecations

Conversation

@segiddins
Copy link
Copy Markdown
Contributor

@segiddins segiddins commented Jun 15, 2018

What was the end-user problem that led to this PR?

The problem was, actually I'm not sure. @indirect ?

Addresses the first bullet point in #6582.

What was your diagnosis of the problem?

My diagnosis was we should only hard error on deprecations in the major version after we stop supporting them.

@indirect
Copy link
Copy Markdown

indirect commented Jun 15, 2018

The problem was we removed e.g. with_clean_env without a deprecation period, instantly breaking any application that upgraded from Bundler 1 to 2. My recollection of the steps leading up to this is:

  1. We planned to ship version 1.99 and version 2.0 at the same time, with warnings in 1.99 and breaking in 2.0.
  2. We realized that most people run gem install bundler, and would therefore miss out on the warnings from 1.99, so we decided to drop the 1.99 release.
  3. At that point, we had 2.0 with breaking changes, but no version with warnings for those breaking changes.
  4. User feedback convinced us to guarantee a period of warning-without-breakage, and the easiest way to make that happen is by printing warnings in this version, and having the change break in the next version.

@indirect
Copy link
Copy Markdown

indirect commented Jun 21, 2018

@bundlerbot r+

@bundlerbot
Copy link
Copy Markdown
Collaborator

bundlerbot commented Jun 21, 2018

📌 Commit bb0cc7c has been approved by indirect

@bundlerbot
Copy link
Copy Markdown
Collaborator

bundlerbot commented Jun 21, 2018

⌛ Testing commit bb0cc7c with merge d44d803...

bundlerbot added a commit that referenced this pull request Jun 21, 2018
@bundlerbot
Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=…
d44d803 
…indirect

[SharedHelpers] Only hard-error on major deprecations in the following version

### What was the end-user problem that led to this PR?

The problem was, actually I'm not sure. @indirect ?

Addresses the first bullet point in #6582.

### What was your diagnosis of the problem?

My diagnosis was we should only hard error on deprecations in the major version _after_ we stop supporting them.
@bundlerbot
Copy link
Copy Markdown
Collaborator

bundlerbot commented Jun 21, 2018

☀️ Test successful - status-travis
Approved by: indirect
Pushing d44d803 to master...

@bundlerbot bundlerbot merged commit bb0cc7c into master Jun 21, 2018
@deivid-rodriguez deivid-rodriguez deleted the segiddins/softer-major-deprecations branch September 3, 2018 22:44
colby-swandale pushed a commit that referenced this pull request Feb 8, 2019
@bundlerbot
Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=…
d43b4fb 
…indirect

[SharedHelpers] Only hard-error on major deprecations in the following version

### What was the end-user problem that led to this PR?

The problem was, actually I'm not sure. @indirect ?

Addresses the first bullet point in #6582.

### What was your diagnosis of the problem?

My diagnosis was we should only hard error on deprecations in the major version _after_ we stop supporting them.

(cherry picked from commit d44d803)
colby-swandale pushed a commit that referenced this pull request Feb 10, 2019
Merge branch '2-0-stable'
ccca7a6 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...
colby-swandale pushed a commit that referenced this pull request Feb 12, 2019
Merge branch '2-0-stable'
77f4c15 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...
@deivid-rodriguez deivid-rodriguez mentioned this pull request Feb 14, 2019
Merged
colby-swandale pushed a commit that referenced this pull request Feb 18, 2019
1
c348978 
* commit '77f4c15451aaac135d19ac5d1637981d7b05d799': (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...
colby-swandale pushed a commit that referenced this pull request Feb 20, 2019
Merge branch '2-0-stable'
dcd92c7 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
deivid-rodriguez pushed a commit that referenced this pull request Feb 28, 2019
@deivid-rodriguez
Merge branch '2-0-stable'
ee02a03 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
deivid-rodriguez pushed a commit that referenced this pull request Mar 13, 2019
@deivid-rodriguez
Merge branch '2-0-stable'
4b7a654 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
deivid-rodriguez pushed a commit that referenced this pull request Mar 13, 2019
@deivid-rodriguez
Merge branch '2-0-stable'
b1d2b48 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
deivid-rodriguez pushed a commit that referenced this pull request Mar 15, 2019
@deivid-rodriguez
Merge branch '2-0-stable'
e6d4f41 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
deivid-rodriguez pushed a commit that referenced this pull request Mar 20, 2019
@deivid-rodriguez
Merge branch '2-0-stable'
e590c0f 
* 2-0-stable: (43 commits)
  remove path that i copied from my personal computer
  Auto merge of #6586 - bundler:segiddins/softer-major-deprecations, r=indirect
  Merge #6941
  Merge #6834
  Version 2.0.1 with changelog
  update tested rubygems in travis
  Lower required RubyGems to 2.5 or greater
  Bundler 2.0 with changelog
  update CHANGELOG with new changes and release
  Merge #6856
  add RubyGems v3.0.1 to rg clone task
  Version 2.0.0.pre.3 wih changelog
  update tested versions of RubyGems in travis
  update gemspec to require RubyGems 3.0.0
  Merge #6849
  Merge #6853
  Revert "Version 2.0.0 with changelog"
  Version 2.0.0 with changelog
  fix breaking edge case spec
  Merge #6818
  ...

(cherry picked from commit 77f4c15)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@segiddins @indirect @bundlerbot