Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delayed_job to fix deprecation warning #4864

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

coalest
Copy link
Collaborator

@coalest coalest commented Dec 16, 2024

Doesn't resolve any issue

Description

Noticed a deprecation warning popping up:
image

Commented out gems and ran ruby -rbundler/setup -e "Bundler.require" until I got the warning to stop. Turned out to be delayed_job causing the issue. That issue was fixed in this delayed job PR. So upgrading to the latest version fixed the issue.

Type of change

  • Internal (Dependency upgrade)

How Has This Been Tested?

Just by running the test suite. It is a minor version change, so in theory there shouldn't be any breaking changes here.

@cielf
Copy link
Collaborator

cielf commented Dec 16, 2024

I just put a similar thing into the backlog -- getting this when bin/starting on my local

_
11:46:03 worker.1 | DEPRECATION WARNING: ActiveSupport::ProxyObject is deprecated and will be removed in Rails 8.0.
11:46:03 worker.1 | Use Ruby's built-in BasicObject instead.
11:46:03 worker.1 | (called from

at /Users/clfisher/projects/human-essentials/config/application.rb:7)
11:46:03 web.1 | DEPRECATION WARNING: ActiveSupport::ProxyObject is deprecated and will be removed in Rails 8.0.
11:46:03 web.1 | Use Ruby's built-in BasicObject instead.
11:46:03 web.1 | (called from at /Users/clfisher/projects/human-essentials/config/application.rb:7)
11:46:12 _

What you've got's not also going to fix that, is it? (I suspect not)

@coalest
Copy link
Collaborator Author

coalest commented Dec 17, 2024

@cielf Yea that's the deprecation warning this PR should fix. You can test it out either by checking this branch out, or running the same command I did on this branch (bundle update delayed_job). It should make the warning disappear.

@cielf
Copy link
Collaborator

cielf commented Dec 17, 2024

I thought it might not be because of where it was failing (not obviously to do with delayed_job) , but it seems to have fixed it there as well.

@coalest
Copy link
Collaborator Author

coalest commented Dec 17, 2024

Yea, the backtrace doesn't really give any clue as to where the issue is coming from, because that line in config/application.rb is when bundle requires all of the dependencies. But it doesnt tell you which dependency.

And I think dependabot didn't create a PR to update this gem, because its a dependency of gems in the gemfile, but not directly in the gemfile itself

@cielf cielf requested a review from dorner December 18, 2024 00:54
@dorner
Copy link
Collaborator

dorner commented Dec 18, 2024

Thanks!

@dorner dorner merged commit 8fcbef4 into rubyforgood:main Dec 18, 2024
11 checks passed
Copy link
Contributor

@coalest: Your PR Update delayed_job to fix deprecation warning is part of today's Human Essentials production release: 2024.12.22.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants