Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address ActiveSupport::ProxyObject deprecation on Rails 7.2.0.alpha #1209

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Address ActiveSupport::ProxyObject deprecation on Rails 7.2.0.alpha #1209

merged 1 commit into from
Aug 13, 2024

Conversation

joshuay03
Copy link

@joshuay03 joshuay03 commented Apr 30, 2024 •
edited
Loading

ActiveSupport::ProxyObject has been deprecated on Rails main i.e. 7.2.0.alpha. The recommended alternative is Ruby's BasicObject:

Delayed::Compatibility.proxy_object_class
DEPRECATION WARNING: ActiveSupport::ProxyObject is deprecated and will be removed in Rails 7.3.
Use Ruby's buildin BasicObject instead.
 (called from <module:Delayed> at /rails/vendor/bundle/ruby/3.2.0/gems/delayed_job-4.1.11/lib/delayed/message_sending.rb:2)

which has been around since Ruby 1.9.

There's some additional functionality that ActiveSupport::ProxyObject has over BasicObject, but from what I can tell, those aren't being used in this specific case.

@joshuay03 joshuay03 force-pushed the internal/address-active-support-proxy-object-deprecation branch from 47e74fd to 0f2f05a Compare April 30, 2024 03:26
@joshuay03 joshuay03 changed the title Address ActiveSupport::ProxyObject deprecation on Rails 7.2.0.alpha Address ActiveSupport::ProxyObject deprecation on Rails 7.2.0.alpha Apr 30, 2024
@joshuay03 joshuay03 force-pushed the internal/address-active-support-proxy-object-deprecation branch from 0f2f05a to 25469d9 Compare April 30, 2024 03:28
@samithoughtbot
Copy link

Can someone review this? I nearly just went and made this change..

@albus522 albus522 merged commit 25469d9 into collectiveidea:master Aug 13, 2024
@joshuay03 joshuay03 deleted the internal/address-active-support-proxy-object-deprecation branch August 14, 2024 06:30
@coalest coalest mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samithoughtbot samithoughtbot samithoughtbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuay03 @samithoughtbot @albus522