[#4807] Help partner to remember to submit profile for approval: #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roval: * Duplicate partner actions at top and bottom of long view * Extract action sto partial to avoid code duplication * Maintain partner system tests
|
@danielabar: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4807
Description
A quick follow-on from #4789.
This duplicates the action buttons/links "Submit for Approval" and "Update Information" at the top of the Partner Profile view (they continue to render at the bottom of the view). Since it's a long view, this serves as a visual reminder to the partner user that they still need to submit their profile for approval.
Note that this feature is not behind the flag (
Flipper.enable(:partner_step_form)) because it's useful even without step-wise editing. i.e. the partner profile view is long regardless.Tech Notes
Took this opportunity to extract the actions to a partial with strict locals for the
partnervariable, which is required to determine what actions get displayed.Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Maintained system tests at
spec/system/partners/approval_process_spec.rbFor manual testing:
http://localhost:3000/partners/profileand should see the action buttons "Submit for Approval" and "Update Information" both at top and bottom of the view.Screenshots
The same action buttons (that are actually links) added to top of view:
