-
-
Notifications
You must be signed in to change notification settings - Fork 538
4596-Restore "reset password" capability -- banks to reset password for partners. #4605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cielf
merged 7 commits into
rubyforgood:main
from
ewoknock:4596-restore_reset_password_capability
Aug 24, 2024
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
282d9dd
Adds in action for reset_password_partner_user
ewoknock 50650bc
Adds in and stylizes the reset password button on 'Manage Users' page
ewoknock 1a1fca8
Adds in rspec for new controller action
ewoknock f3a9dc4
Updates rspec for reset password
ewoknock b91207d
Changes icon on reset-password to a key
ewoknock 44a816b
Updating rspec test description to be more accurate
ewoknock beab008
Merge branch 'main' into 4596-restore_reset_password_capability
cielf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,4 +111,23 @@ | |
end | ||
end | ||
end | ||
|
||
describe "POST #reset_password" do | ||
let!(:partner_user) do | ||
UserInviteService.invite( | ||
email: "[email protected]", | ||
name: "Meow Mix", | ||
roles: [Role::PARTNER], | ||
resource: partner | ||
) | ||
end | ||
|
||
context "when the partner needs to reset a user's password" do | ||
it "resends the reset password email and redirects back to root_path" do | ||
expect { post reset_password_partner_user_path(default_params.merge(partner_id: partner, id: partner_user)) }.to change { ActionMailer::Base.deliveries.count }.by(1) | ||
expect(response).to redirect_to(root_path) | ||
expect(flash[:notice]).to eq("Password e-mail sent!") | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be when a bank needs to reset a partner user's password?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, that would be a more accurate description.
Should I make the change and, if so, how would I add it to this pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please. When you push your changes to github, they will automatically come through to this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I've made that update!