-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4596-Restore "reset password" capability -- banks to reset password for partners. #4605
4596-Restore "reset password" capability -- banks to reset password for partners. #4605
Conversation
This commit adds in a new action to the partner_users_controller to reset the corresponding user's password. It also adds in a new route for the action -reset_password_partner_user -/partners/:partner_id/users/:id/reset_password(.:format) -partner_users#reset_password [Ticket: 4596]
Adds in check for ActionMailer count increases by 1 Adds in check for the expected notice message [Ticket: 4596]
Looks good, functionality-wise. |
) | ||
end | ||
|
||
context "when the partner needs to reset a user's password" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be when a bank needs to reset a partner user's password?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, that would be a more accurate description.
Should I make the change and, if so, how would I add it to this pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please. When you push your changes to github, they will automatically come through to this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I've made that update!
All good on my end! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright then, let's merge it!
@ewoknock: Your PR |
Resolves #4596
Description
Added in the "Reset Password" button to the "Manage Users" Partner page.
I implemented this by adding a new action to the partner_users_controller, and added the corresponding route.
There was an existing action under the users_controller to also reset the partner's password, but this did not seem to fit the goal of this issue. This led me to create a new action under the partner_users controller instead.
Type of change
How Has This Been Tested?
For testing, I first tested it by navigating to various partners and verifying that the Reset Password button correctly generated a new email with the correct email address.
I then created an rspec test that executed the new action and verified that a new mailer was created, it redirected successfully, and the correct notice message was flashed.
Screenshots