Fix regression where yanked gems are now unintentionally updated when other gems are unlocked#5812
Merged
deivid-rodriguez merged 4 commits intomasterfrom Aug 6, 2022
Merged
Conversation
…cked This is a regression from a change intended to raise errors when user puts a gem under an incorrect source in the Gemfile by mistake. To fix the issue, we revert the change that caused it and implement it in a different way that restores the resolver independency from real specifications. Now it deals only with names and versions and does not try to materialize anything into real specifications before resolving.
deivid-rodriguez
force-pushed
the
fix-yank-unlocks
branch
from
51c3907 to
d2bf1b8
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Aug 10, 2022
Fix regression where yanked gems are now unintentionally updated when other gems are unlocked (cherry picked from commit 8329726)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
#5070 caused a regression where updating specific gems in a lockfile, for example, through
bundle lock --update foo, would also update unrelated gems, just because their locked version is yanked.Issue was detected by dependabot-core test suite at dependabot/dependabot-core#5465.
What is your fix for the problem, implemented in this PR?
My fix is to revert #5070 and take a different approach to fix the issue that does not involve coupling the resolver with materializing bare spec information into real gem specifications.
Make sure the following tasks are checked