Skip to content

Bundler: Bump bundler from 2.3.18 to 2.3.19#5465

Closed
jurre wants to merge 1 commit intomainfrom
jurre/bundler-2.3.19
Closed

Bundler: Bump bundler from 2.3.18 to 2.3.19#5465
jurre wants to merge 1 commit intomainfrom
jurre/bundler-2.3.19

Conversation

@jurre
Copy link
Copy Markdown
Member

@jurre jurre commented Aug 2, 2022

Copy link
Copy Markdown
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man we specify this version a lot of places!

@jeffwidman
Copy link
Copy Markdown
Member

@jurre would it make sense to first merge #4973 and then do this?

Either way there will be merge conflicts, and they'd be a lot easier to deal with here since it would become a one-line change vs there it'd be a multi-line fixup.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

Regardless of which one is merged first, there seems to be a problem with the latest Bundler that makes one spec fail... 🤔. I'll have a look.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

Issue bisected and working on a fix now 👍.

@jurre
Copy link
Copy Markdown
Member Author

jurre commented Aug 4, 2022

Going to close this out because of #5479 for now

@jurre jurre closed this Aug 4, 2022
@deivid-rodriguez
Copy link
Copy Markdown
Contributor

Great! The regression in 2.3.19 should be fixed by ruby/rubygems#5812, so it should be all good for Bundler 2.3.20 when it's released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants