Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer assert_include for simple strings #632

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Prefer assert_include for simple strings #632

merged 1 commit into from
Jun 12, 2023

Conversation

nobu
Copy link
Member

@nobu nobu commented Jun 8, 2023

Using regexps unnecessarily sometimes leads to mistakes, like #628.

@hsbt hsbt merged commit fac85ac into ruby:master Jun 12, 2023
@nobu nobu deleted the test-include branch October 10, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsbt hsbt hsbt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nobu @hsbt