Ensure strings that may be confused as YAML1.2 numbers are quoted #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adammw
force-pushed
the
adammw/yaml12-number
branch
from
9ae719c
to
5279e18
Compare
nobu
reviewed
Jun 8, 2023
Comment on lines
+176
to
+182
| assert_match(/'0o17'/, Psych.dump({'a' => '0o17'})) | ||
| assert_match(/'0o111'/, Psych.dump({'a' => '0o111'})) | ||
|
|
||
| # YAML 1.2 float Number | ||
| assert_match(/'12e03'/, Psych.dump({'a' => '12e03'})) | ||
| assert_match(/'1.2e3'/, Psych.dump({'a' => '1.2e3'})) | ||
| assert_match(/".2e3"/, Psych.dump({'a' => '.2e3'})) |
There was a problem hiding this comment.
. (any character) does not seem what you want here.
Suggested change
| assert_match(/'0o17'/, Psych.dump({'a' => '0o17'})) | |
| assert_match(/'0o111'/, Psych.dump({'a' => '0o111'})) | |
| # YAML 1.2 float Number | |
| assert_match(/'12e03'/, Psych.dump({'a' => '12e03'})) | |
| assert_match(/'1.2e3'/, Psych.dump({'a' => '1.2e3'})) | |
| assert_match(/".2e3"/, Psych.dump({'a' => '.2e3'})) | |
| assert_include(Psych.dump({'a' => '0o17'}), "'0o17'") | |
| assert_include(Psych.dump({'a' => '0o111'}), "'0o111'") | |
| # YAML 1.2 float Number | |
| assert_include(Psych.dump({'a' => '12e03'}), "'12e03'") | |
| assert_include(Psych.dump({'a' => '1.2e3'}), "'1.2e3'") | |
| assert_include(Psych.dump({'a' => '.2e3'}), '".2e3"') |
There was a problem hiding this comment.
Also, the last ".2e3" seems from YAML 1.1, right?
|
@adammw Any chance you have time to continue working on this? I've run into this same problem where strings (git commit SHAs) that look like scientific notation are dumped with no quotes around them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure strings that may be confused as YAML1.2 numbers are quoted.
Example:
0o123or1e3strings in Ruby will be printed without quotation marks, resulting in them changing to numbers in a YAML1.2-parser (like that used in Go).Fixes #627