Freeze parsing option #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
freeze-parsing-option
branch
from
74dbd38
to
7b0e018
Compare
|
@casperisfine can you rebase this and I'll merge it? |
casperisfine
force-pushed
the
freeze-parsing-option
branch
from
7b0e018
to
7dae248
Compare
|
@tenderlove done! |
|
@casperisfine thank you! |
|
You're most welcome! |
This was referenced Sep 4, 2020
paracycle
added a commit
to Shopify/sorbet
that referenced
this pull request
Oct 8, 2020
The `freeze` parsing option was added almost a year ago in upstream PR: ruby/psych#414 This commit reflects those changes in the RBI file.
paracycle
added a commit
to Shopify/sorbet
that referenced
this pull request
Oct 8, 2020
The `freeze` parsing option was added almost a year ago in upstream PR: ruby/psych#414 This commit reflects those changes in the RBI file.
paracycle
added a commit
to Shopify/sorbet
that referenced
this pull request
Oct 8, 2020
The `freeze` parsing option was added almost a year ago in upstream PR: ruby/psych#414 This commit reflects those changes in the RBI file.
jez
pushed a commit
to sorbet/sorbet
that referenced
this pull request
Oct 17, 2020
The `freeze` parsing option was added almost a year ago in upstream PR: ruby/psych#414 This commit reflects those changes in the RBI file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: ruby/ruby#2287 (comment)
Followup: #409
With this option enabled:
String#-@.Note that I had to first refactor
symbolize_names, because it was mutating the data structures at the end of the parsing phase.Also, we could go a bit further and deduplicate some specific objects such as empty hashes and arrays, but I opted to keep this PR as simple as possible.
@tenderlove @rafaelfranca @Edouard-chin