Implement a freeze: parser option #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
global-freeze-option
branch
2 times, most recently
from
de7693a
to
94e4064
Compare
|
cc @marcandre @tenderlove could I interest one of you into this feature? |
casperisfine
force-pushed
the
global-freeze-option
branch
from
94e4064
to
c9bbb5f
Compare
I went ahead and implemented it anyway. It wasn't that complicated actually. |
marcandre
approved these changes
Sep 14, 2020
|
Thanks @marcandre. cc @hsbt is this something you could consider merging? |
hsbt
reviewed
Sep 15, 2020
casperisfine
force-pushed
the
global-freeze-option
branch
2 times, most recently
from
b0255ee
to
3a56c08
Compare
If set to true all parsed objects will be immediately frozen, and strings will be deduplicated if the Ruby implementation allows it.
casperisfine
force-pushed
the
global-freeze-option
branch
from
3a56c08
to
9bf8aa2
Compare
|
It should be good to go now. CI is green. |
|
@hsbt anything else you'd like changed? |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Open
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If set to true all parsed objects will be immediately frozen, and strings will be deduplicated if the Ruby implementation allows it.
This option is useful if you plan to keep the parsed objects around, and want to reduce their memory footprint, and you know they contain duplicated string. It's common in says I18n data, or some database like configuration files (e.g. tax rates etc).
A similar option was added to YAML/Pysch: ruby/psych#414
MessagePack is also about to have it: msgpack/msgpack-ruby#194 (at least the principle was accepted).
Right now this option incur a small overhead because it has to call
String#-@throughrb_funcall, but hopefully Ruby 3.0 should soon exposerb_fstring_new(const char *ptr, long len) (likely under another name)which should allow to reduce allocations by directly looking up existing strings without allocating a new one.NB: I presume that a java implementation is needed, I'm not too well versed into Java by I can try my hand at it. However I'd rather have your feedback on the MRI and "pure" implementations first.