Skip to content

Use the open_timeout kwarg where available #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use the open_timeout kwarg where available #95

wants to merge 1 commit into from

Conversation

@mohamedhafez
Copy link
Contributor

@mohamedhafez mohamedhafez commented Nov 10, 2025 •
edited
Loading

Resolves #94

equivalent change to what @osyoyu did in ruby/net-http#224

Some justification copied over from that PR's description:

The builtin timeout in TCPSocket.open is better in several ways. First, it does not rely on a separate Ruby Thread for monitoring Timeout (which is what the timeout library internally does). Also, it is compatible with Ractors, since it does not rely on Mutexes (which is also what the timeout library does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace Timeout.timeout with TCPSocket.open(open_timeout:) when available

1 participant

@mohamedhafez