backwards compatible to very old ruby

Author: mohamedhafez

lib/net/smtp.rb

@@ -660,8 +660,12 @@ def finish
 
     private
 
-    def tcp_socket(*args, **kwargs)
-      TCPSocket.open(*args, **kwargs)
+    def tcp_socket(address, port, open_timeout: nil)
+      if open_timeout
+        TCPSocket.open(address, port, nil, nil, open_timeout: open_timeout)
+      else
+        TCPSocket.open(address, port)
+      end
     end
 
     def do_start(helo_domain, user, secret, authtype)
@@ -674,7 +678,7 @@ def do_start(helo_domain, user, secret, authtype)
           case @tcp_socket_supports_open_timeout
           when nil, true
             begin
-              sock = tcp_socket(@address, @port, nil, nil, open_timeout: @open_timeout)
+              sock = tcp_socket(@address, @port, open_timeout: @open_timeout)
               @tcp_socket_supports_open_timeout = true
               sock
             rescue ArgumentError => e

test/net/smtp/test_sslcontext.rb

@@ -21,7 +21,7 @@ def initialize(socket, **kw)
         super("localhost", **kw)
       end
 
-      def tcp_socket(*args, **kwargs)
+      def tcp_socket(*)
         @fake_socket
       end
 

test/net/smtp/test_starttls.rb

@@ -14,7 +14,7 @@ def initialize(socket)
         super("smtp.example.com")
       end
 
-      def tcp_socket(*args, **kwargs)
+      def tcp_socket(*)
         @fake_socket
       end