Skip to content

Conversation

georgekettle
Copy link
Collaborator

Fixes:

  • Spacing wasn't being obeyed for FormField as the label was not inline-block
  • Error message looked a little big, so I reduced the sizing of this component

See updated design below:

Screenshot 2025-10-12 at 12 26 36 pm

@georgekettle georgekettle requested a review from cirdes as a code owner October 12, 2025 01:29
@georgekettle georgekettle changed the title Error to xs sizing and label to inline-block to maintain spacing of FormField wrapper Minor fixes to FormField component styling Oct 12, 2025
Copy link
Collaborator

@cirdes cirdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgekettle , happy to see your commits again! ❤️❤️❤️

@cirdes cirdes merged commit 7762d34 into main Oct 14, 2025
2 checks passed
@cirdes cirdes deleted the fix-form-field-styling branch October 14, 2025 12:15
@georgekettle
Copy link
Collaborator Author

So thankful for all the work you've put into this project! @cirdes , @sethhorsley and others 💛 I think this project is really important for the ruby community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants