Skip to content

Fix broken install command #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harrysarson merged 5 commits into from
Nov 17, 2020
Merged

Fix broken install command #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef763d4
Fix broken install command
lydell Nov 15, 2020
de533dc
Trigger build
lydell Nov 15, 2020
5feb796
Trigger build
lydell Nov 15, 2020
ba11bc4
Add test
lydell Nov 15, 2020
1cb199c
Merge branch 'master' into fix-install-command
lydell Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elm-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ function main() {
.description(
'Like `elm install package`, except it installs to "test-dependencies" in your elm.json'
)
.action(([packageName], cmd) => {
.action((packageName, cmd) => {
if (cmd.args.length > 1) {
// Unfortunately commander is very permissive about extra arguments. Therefore,
// we manually check for excessive arguments.
Expand Down
6 changes: 6 additions & 0 deletions tests/flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,12 @@ describe('flags', () => {
assert(!runResult.stdout.includes('FINDME'));
assert(!runResult.stderr.includes('FINDMETWICE'));
}).timeout(60000);

it('should exit with success if package already installed', () => {
const runResult = execElmTest(['install', 'elm-explorations/test']);
console.log(runResult);
assert.strictEqual(runResult.status, 0);
}).timeout(60000);
});

describe('elm-test make', () => {
Expand Down