Fix broken install command#470
Merged
harrysarson merged 5 commits intortfeldman:masterfrom Nov 17, 2020
Merged
Conversation
Collaborator
|
Nice catch! Could you add a regression test? |
Collaborator
Author
|
Do you have any ideas on how to write one? |
Collaborator
Author
|
I figured it out. |
Collaborator
|
It looks like travis has pulled macos support. I guess we cannot complain too much because we were getting it for free. @lydell could you remove mac from travis just so we can get a green tick. Longer time we probably want to migrate to github actions. Cc: @rtfeldman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #465.
Before:
After:
This happened because I thought the first argument of the
.actioncallback is always an array. Wrong! The signature depends on the.commandsyntax provided:For the install command we have:
Before we tried to destructure the first argument (thinking it was an array), so we only got the first letter of the package name.
Unfortunately our test suite doesn’t catch this.