handle new prefix in fontawesome 5 #1967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #1554
Following fontawesome update to V5 in #1340, there was some missing changes for Rmarkdown website, for which icon can be set in navbar using
icon:
With this change, I believe it will not break current behavior as
ion ion-...
fa-home
. in that casefas
prefix will be added - the new default one.fab fa-r-project
. In that case, the full name will be used as class for the span.I have chosen to not be specific on the prefix using
fa\\w
, but we could only check for supported prefixfa(b|s|r|l|d)
instead.This is a quick fix without rethinking the all logic for icons.
I did not find any documentation in the package.
Maybe I should update https://bookdown.org/yihui/rmarkdown/rmarkdown-site.html ?