Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify use of fontawesome icon for navbar - no prefix required #2042

Open
cderv opened this issue Feb 10, 2021 · 3 comments
Open

Simplify use of fontawesome icon for navbar - no prefix required #2042

cderv opened this issue Feb 10, 2021 · 3 comments
Assignees
Labels
feature a feature request or enhancement next to consider for next release theme: icons related to icons in Rmd documents (fontawesome, ...)

Comments

@cderv
Copy link
Collaborator

cderv commented Feb 10, 2021

Following the different PR we have regarding fontawesome

After @gadenbuie challenge a bit the current fix, I looked into how shiny handles it : Basically the maintain a list of brands icon and add the fab prefix if needed. This helps for using V4 and V5 with simply the name of the icon.

Also it uses an update script that would be useful to easily update the dependency here too. I believe keeping in sync the version in both shiny and rmarkdown is better.

So we should do something inspired by the logic in shiny, and maybe this would solve also what #1994 is trying to solve.

@cderv
Copy link
Collaborator Author

cderv commented Feb 11, 2021

Related also to the update of FA: #1661

@cderv
Copy link
Collaborator Author

cderv commented Feb 22, 2021

We'll use the new on CRAN fontawesome package now.

@cderv cderv added feature a feature request or enhancement and removed enhancement labels Apr 14, 2021
@cderv cderv added the next to consider for next release label May 18, 2021
@cderv cderv self-assigned this Jan 6, 2022
@cderv cderv moved this to Backlog in R Markdown Team Projects Jan 6, 2022
@cderv cderv moved this from Backlog to Todo in R Markdown Team Projects Jan 6, 2022
@cderv cderv added the theme: icons related to icons in Rmd documents (fontawesome, ...) label Jan 11, 2022
@cderv cderv moved this from Backlog to Next in R Markdown Team Projects Feb 9, 2023
@cderv cderv assigned cderv and rich-iannone and unassigned cderv Feb 14, 2023
@rich-iannone
Copy link
Member

Note: this may work now with the new fontawesome dependency, need to test to confirm.

@rich-iannone rich-iannone moved this from Next / Ready for Dev to Backlog in R Markdown Team Projects Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement next to consider for next release theme: icons related to icons in Rmd documents (fontawesome, ...)
Projects
Status: Backlog
Development

No branches or pull requests

2 participants