Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dependencies to fix vulnerability #3

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

fuzetsu
Copy link
Contributor

@fuzetsu fuzetsu commented Jul 2, 2021

Hi, thanks for this tool, just what I needed 😄

I was getting some npm audit errors through this package because of semver: https://www.npmjs.com/advisories/31

While fixing that I took the chance to update all the dependencies (hopefully that's alright).

The tool still seems to work, and the tests all pass (with a small tweak, looks like .falsy went away at some point).

I didn't look in detail to see what changed in chai/mocha/sinon in those major versions, but the tests pass and there weren't any warnings/errors in the console so I think we're OK 😅

@fuzetsu fuzetsu changed the title upgrade all dependencies to their latest version upgrade dependencies to fix vulnerability Jul 2, 2021
@rstacruz rstacruz merged commit 86a4bb6 into rstacruz:master Jul 10, 2021
@rstacruz
Copy link
Owner

Thanks! Just released this onto npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants