diff-lcs has changed its format in 1.4
#421
Conversation
This commit deals with both versions, as its just header notation thats changed. I'm not sure either is more correct than the other but its harmless to our diffing process. Some additional `\n` changes are due to the string type change, `"\\n"` is the same as `'\n'`.
JonRowe
force-pushed
the
fix-differ-support
branch
5 times, most recently
from
f7e2912 to
de1b664
Compare
JonRowe
force-pushed
the
fix-differ-support
branch
from
de1b664 to
0816dff
Compare
|
Related I've asked the diff-lcs team to bump their major version if they make Ruby changes in halostatue/diff-lcs#62 they have dropped "soft" support for older rubies, which in turn means |
JonRowe
force-pushed
the
fix-differ-support
branch
2 times, most recently
from
9ee1b82 to
68a10d1
Compare
|
Can you detail the changes that were breaking for you on this with examples as a bug against |
|
@halostatue This PR contains examples of the changed output, the line number headers have changed in some cases, and some unchanged lines have been removed, I'm totally fine with working around that in the two versions like this PR does :) |
benoittgt
left a comment
benoittgt
left a comment
There was a problem hiding this comment.
Thanks for all the changes in differ_spec. It is much better like this.
| | | ||
| |@@ #{one_line_header} @@ | ||
| |-Tu avec carte {count} item has | ||
| |+Tu avec carté {count} itém has |
There was a problem hiding this comment.
Lol this means nothing in french. 😅
There was a problem hiding this comment.
Nothing like a good bit of franglais, its only the é thats important if you'd like to make it make sense :P
JonRowe
force-pushed
the
fix-differ-support
branch
from
d5f8ed2 to
3227c85
Compare
JonRowe
force-pushed
the
fix-differ-support
branch
2 times, most recently
from
1a3e673 to
ca6729a
Compare
`diff-lcs` has changed its format in 1.4
…iffer-support `diff-lcs` has changed its format in 1.4 --- This commit was imported from rspec/rspec-support@9cceff0.
3 participants
The recent
diff-lcsupdate changed some parts of the diff output, breaking our builds, these seem trivial enough to ignore (e.g. they don't seem wrong, just different).Draft because I'm going to improve the formatting of this spec a bit whilst I'm here, and I'm going to setup CI to test both versions of
diff-lcs.