Update dependencies #727
Merged
Update dependencies #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
update-dependencies
branch
from
16ad378 to
77a16e6
Compare
Contributor
Author
|
Tests are failing, it seems due to a subtle difference in the output of diffs between diff-lcs 1.3 and 1.4. |
Contributor
Author
|
See rspec/rspec-support#421 for more details on the diff changes due to diff-lcs. Looks like we'll need to loosen the expectations so both behaviors will be considered fine. |
This keeps the 'Diff:' part to indicate that some kind of diff should be output, but doesn't dictate the format of the diff, since that detail is not really important for this scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update dependencies to allow their latest versions
Details
Motivation and Context
Aruba should support testing with latest Cucumber
How Has This Been Tested?
Travis will check that installation proceeds correctly on all supported Ruby versions, in particular on 2.4, which is not supported by Cucumber 5.
Types of changes