Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix turbo dev command errors #1229

Merged
merged 2 commits into from
Jun 2, 2023
Merged

fix turbo dev command errors #1229

merged 2 commits into from
Jun 2, 2023

Conversation

YunFeng0817
Copy link
Member

fixes #1221
If I haven't executed yarn republish command and run yarn dev command directly, the issue can be reproduced.

The reason is that the dev command doesn't define the dependent order between packages, so some output of dependent packages is absent at the running time.

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

🦋 Changeset detected

Latest commit: a9ac193

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Juice10 Juice10 merged commit a606109 into master Jun 2, 2023
@Juice10 Juice10 deleted the fix-dev-command branch June 2, 2023 09:25
eoghanmurray pushed a commit to eoghanmurray/rrweb that referenced this pull request Jul 27, 2023
* fix turbo dev command errors

* Create forty-elephants-attack.md

---------

Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray pushed a commit to eoghanmurray/rrweb that referenced this pull request Jul 27, 2023
* fix turbo dev command errors

* Create forty-elephants-attack.md

---------

Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray pushed a commit to eoghanmurray/rrweb that referenced this pull request Jul 27, 2023
* fix turbo dev command errors

* Create forty-elephants-attack.md

---------

Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray pushed a commit to eoghanmurray/rrweb that referenced this pull request Aug 3, 2023
* fix turbo dev command errors

* Create forty-elephants-attack.md

---------

Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray pushed a commit to eoghanmurray/rrweb that referenced this pull request Aug 8, 2023
* fix turbo dev command errors

* Create forty-elephants-attack.md

---------

Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray pushed a commit to eoghanmurray/rrweb that referenced this pull request Aug 8, 2023
* fix turbo dev command errors

* Create forty-elephants-attack.md

---------

Co-authored-by: Justin Halsall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: Could not load ./rrweb-master/packages/types/dist/types.js
2 participants