Guard against redefinition of Date.now #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 005f649 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
reviewed
Apr 7, 2023
eoghanmurray
force-pushed
the
nowTimestamp
branch
from
0a638e5 to
43b4889
Compare
…e)define Date.now, e.g. datejs/Datejs#92
…rweb-replay output
Fix typing issue with regex against `Date.now()` Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray
force-pushed
the
nowTimestamp
branch
from
43b4889 to
d3b67af
Compare
Juice10
reviewed
Jun 2, 2023
Juice10
approved these changes
Jun 2, 2023
|
Lets add https://github.com/willklein/eslint-plugin-disallow-methods to the project and add |
|
There's quite a few valid Date.now() present on the replay side which is fine so we'll have to 'police' this manually. We could add it as an |
This was referenced Jun 14, 2023
This was referenced Jul 6, 2023
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
* Guard against presence of likely older third party libraries which (re)define Date.now, e.g. datejs/Datejs#92 * Apply formatting changes * (remove nowTimestamp import where Date.now() is not used) * Add a PURE marker so an empty `ìf` statement doesn't show up in the rrweb-replay output * Update packages/rrweb/src/utils.ts Fix typing issue with regex against `Date.now()` Co-authored-by: Justin Halsall <[email protected]> * Create little-radios-thank.md * Apply formatting changes * Update .changeset/little-radios-thank.md * Apply formatting changes --------- Co-authored-by: eoghanmurray <[email protected]> Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
* Guard against presence of likely older third party libraries which (re)define Date.now, e.g. datejs/Datejs#92 * Apply formatting changes * (remove nowTimestamp import where Date.now() is not used) * Add a PURE marker so an empty `ìf` statement doesn't show up in the rrweb-replay output * Update packages/rrweb/src/utils.ts Fix typing issue with regex against `Date.now()` Co-authored-by: Justin Halsall <[email protected]> * Create little-radios-thank.md * Apply formatting changes * Update .changeset/little-radios-thank.md * Apply formatting changes --------- Co-authored-by: eoghanmurray <[email protected]> Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
* Guard against presence of likely older third party libraries which (re)define Date.now, e.g. datejs/Datejs#92 * Apply formatting changes * (remove nowTimestamp import where Date.now() is not used) * Add a PURE marker so an empty `ìf` statement doesn't show up in the rrweb-replay output * Update packages/rrweb/src/utils.ts Fix typing issue with regex against `Date.now()` Co-authored-by: Justin Halsall <[email protected]> * Create little-radios-thank.md * Apply formatting changes * Update .changeset/little-radios-thank.md * Apply formatting changes --------- Co-authored-by: eoghanmurray <[email protected]> Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 3, 2023
* Guard against presence of likely older third party libraries which (re)define Date.now, e.g. datejs/Datejs#92 * Apply formatting changes * (remove nowTimestamp import where Date.now() is not used) * Add a PURE marker so an empty `ìf` statement doesn't show up in the rrweb-replay output * Update packages/rrweb/src/utils.ts Fix typing issue with regex against `Date.now()` Co-authored-by: Justin Halsall <[email protected]> * Create little-radios-thank.md * Apply formatting changes * Update .changeset/little-radios-thank.md * Apply formatting changes --------- Co-authored-by: eoghanmurray <[email protected]> Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 8, 2023
* Guard against presence of likely older third party libraries which (re)define Date.now, e.g. datejs/Datejs#92 * Apply formatting changes * (remove nowTimestamp import where Date.now() is not used) * Add a PURE marker so an empty `ìf` statement doesn't show up in the rrweb-replay output * Update packages/rrweb/src/utils.ts Fix typing issue with regex against `Date.now()` Co-authored-by: Justin Halsall <[email protected]> * Create little-radios-thank.md * Apply formatting changes * Update .changeset/little-radios-thank.md * Apply formatting changes --------- Co-authored-by: eoghanmurray <[email protected]> Co-authored-by: Justin Halsall <[email protected]>
eoghanmurray
added a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 8, 2023
* Guard against presence of likely older third party libraries which (re)define Date.now, e.g. datejs/Datejs#92 * Apply formatting changes * (remove nowTimestamp import where Date.now() is not used) * Add a PURE marker so an empty `ìf` statement doesn't show up in the rrweb-replay output * Update packages/rrweb/src/utils.ts Fix typing issue with regex against `Date.now()` Co-authored-by: Justin Halsall <[email protected]> * Create little-radios-thank.md * Apply formatting changes * Update .changeset/little-radios-thank.md * Apply formatting changes --------- Co-authored-by: eoghanmurray <[email protected]> Co-authored-by: Justin Halsall <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard against presence of likely older third party libraries which (re)define Date.now, e.g. datejs/Datejs#92