Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

解决rrvideo 用无头浏览器渲染页面时展示与真实录制的页面渲染不一致 #26

Merged
merged 8 commits into from
Mar 17, 2023

Conversation

xujiujiu
Copy link
Contributor

验证了下,更新了rrweb-player 为最新的版本就好了,目前rrvideo内使用的rrweb-player还是旧仓库的npm,没有随着rrweb/rrweb-player里版本进行更新导致

验证了下,更新了rrweb-player 为最新的版本就好了,目前rrvideo内使用的rrweb-player还是旧仓库的npm,没有随着rrweb/rrweb-player里版本进行更新导致
@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2023

⚠️ No Changeset found

Latest commit: 4ff20b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@xujiujiu
Copy link
Contributor Author

xujiujiu commented Feb 28, 2023

做了下延迟录制 ,解决播放录制到空白块,另外建议默认关闭自动播放,以防倍速录制到空白块
image

Copy link
Member

@YunFeng0817 YunFeng0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常感谢能修复问题, 可否再辛苦把代码中的中文注释修改成英文的

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@xujiujiu xujiujiu requested a review from YunFeng0817 March 10, 2023 10:05
@YunFeng0817 YunFeng0817 merged commit 9326893 into rrweb-io:main Mar 17, 2023
YunFeng0817 added a commit that referenced this pull request Mar 19, 2023
…ge rendering when rendering the page with a headless browser (#26)

Author: xujiujiu <[email protected]>
YunFeng0817 added a commit that referenced this pull request Mar 19, 2023
…ge rendering when rendering the page with a headless browser (#26)

Author: xujiujiu <[email protected]>

---------

Co-authored-by: xujiujiu <[email protected]>
Juice10 pushed a commit to rrweb-io/rrweb that referenced this pull request Mar 28, 2023
* first commit

* rrvideo v0.1.0

First version of rrvideo.

1. Use as a Node.JS lib.
2. Use as a CLI.

Features are implemented via puppeteer, ffmpeg and rrweb-player.

* add readme

* update publish script

* add node env in cli file and change package.json bin to same like README (#4)

Co-authored-by: Xu Yinjie <[email protected]>

* release 0.2.0

* fix #6 avoid assign undefined to config

* Fix: Solve the inconsistency between rrvideo and the real recorded page rendering when rendering the page with a headless browser (rrweb-io/rrvideo#26)

Author: xujiujiu <[email protected]>

---------

Co-authored-by: xujiujiu <[email protected]>

* refactor rrvideo

1. refactor code
2. change monorepo config
3. remove separate TS dependencies

* add changeset

* fix: eslint errors

---------

Co-authored-by: Yanzhen Yu <[email protected]>
Co-authored-by: xyj <[email protected]>
Co-authored-by: Xu Yinjie <[email protected]>
Co-authored-by: xujiujiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants