dnf-repo: fix dnf_repo_get_public_keys double-free#946
Closed
jlebon wants to merge 1 commit intorpm-software-management:dnf-4-masterfrom
Closed
dnf-repo: fix dnf_repo_get_public_keys double-free#946jlebon wants to merge 1 commit intorpm-software-management:dnf-4-masterfrom
jlebon wants to merge 1 commit intorpm-software-management:dnf-4-masterfrom
Conversation
We want to transfer ownership of the strings to the caller, so we shouldn't free the element here. Regression from rpm-software-management#944.
This was referenced Apr 24, 2020
Closed
Contributor
|
Oops, I've missed the pointer is being put into an array in one of the cases there. Thanks for the fix! |
|
📌 Commit cecc9ac has been approved by |
|
💔 Test failed - status-papr |
|
@rh-atomic-bot retry |
|
💔 Test failed - status-papr |
Contributor
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-papr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to transfer ownership of the strings to the caller, so we
shouldn't free the element here.
Regression from #944.