Closed
Conversation
When dnf_context_setup() is called twice, there is memory leak of original content of native_arches. Example where dnf_context_setup() is called twice from libdnf unit tests: ctx = dnf_context_new(); ret = dnf_context_setup(ctx, NULL, &error); and later on: ret = dnf_context_clean_cache(ctx, flags, &error); The dnf_context_clean_cache() function calls dnf_context_setup() and triggers the memory leak.
Contributor
|
📌 Commit 3c631ea has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2020
Closes: #944 Approved by: lukash
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2020
When dnf_context_setup() is called twice, there is memory leak of original content of native_arches. Example where dnf_context_setup() is called twice from libdnf unit tests: ctx = dnf_context_new(); ret = dnf_context_setup(ctx, NULL, &error); and later on: ret = dnf_context_clean_cache(ctx, flags, &error); The dnf_context_clean_cache() function calls dnf_context_setup() and triggers the memory leak. Closes: #944 Approved by: lukash
|
💔 Test failed - status-papr |
Member
Author
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 24, 2020
When dnf_context_setup() is called twice, there is memory leak of original content of native_arches. Example where dnf_context_setup() is called twice from libdnf unit tests: ctx = dnf_context_new(); ret = dnf_context_setup(ctx, NULL, &error); and later on: ret = dnf_context_clean_cache(ctx, flags, &error); The dnf_context_clean_cache() function calls dnf_context_setup() and triggers the memory leak. Closes: #944 Approved by: lukash
|
☀️ Test successful - status-papr |
jlebon
added a commit
to jlebon/libdnf
that referenced
this pull request
Apr 24, 2020
We want to transfer ownership of the strings to the caller here, so we shouldn't free the element here. Regression from rpm-software-management#944.
jlebon
added a commit
to jlebon/libdnf
that referenced
this pull request
Apr 24, 2020
We want to transfer ownership of the strings to the caller, so we shouldn't free the element here. Regression from rpm-software-management#944.
Contributor
|
Follow up to this in #946. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.