Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Expose each variant as its own colorscheme #98

Closed
lukepighetti opened this issue Sep 20, 2022 · 5 comments · Fixed by #114
Closed

feature: Expose each variant as its own colorscheme #98

lukepighetti opened this issue Sep 20, 2022 · 5 comments · Fixed by #114
Labels
enhancement

Comments

@lukepighetti
Copy link

Can't get the moon variant to work, is that supported by this plugin?

...
Plug 'rose-pine/neovim', {'as': 'rose-pine', 'branch': 'main' }
...

colorscheme rose-pine-moon
@mvllow
Copy link
Member

mvllow commented Sep 20, 2022

Absolutely! We have options mentioned in the readme with lua examples. To use them in vimscript:

lua << EOF
require('rose-pine').setup({
	--- @usage 'main' | 'moon'
	dark_variant = 'moon'
})
EOF

colorscheme rose-pine

Be sure that colorscheme is set after the setup :)

@lukepighetti
Copy link
Author

we can't expose multiple themes like tokyonight? https://github.com/folke/tokyonight.nvim#-usage

@mvllow
Copy link
Member

mvllow commented Sep 20, 2022

I'd happily accept a PR that added that functionality. Not a huge priority for me, though.

@mvllow mvllow changed the title Can't use Moon variant Expose each variant as its own colorscheme Sep 23, 2022
@mvllow mvllow mentioned this issue Jan 8, 2023
Merged
4 tasks
@mvllow mvllow changed the title Expose each variant as its own colorscheme feature: Expose each variant as its own colorscheme Jan 13, 2023
@mvllow mvllow mentioned this issue Jan 18, 2023
Closed
mvllow added a commit that referenced this issue Feb 21, 2023
@mvllow
expose each variant as individual theme
8d1620c 
ref #98
mvllow added a commit that referenced this issue Feb 21, 2023
@mvllow
feat: expose each variant as individual theme
4830f68 
ref #98
@mvllow
Copy link
Member

mvllow commented Feb 21, 2023

Added in #114 (canary branch). Will be merged to main soon :)

mvllow added a commit that referenced this issue Feb 22, 2023
@mvllow
Merge canary (#114)
4eac261 
* feat!: use new highlight api

* feat: support custom highlight blending

Example:

```
{
	highlight_groups = {
		StatusLine = { bg = 'love', blend = 10 }
	}
}
```

* refactor: move config into separate file

* wip: update semantic tokens

* ci: add issue templates

Thanks to https://github.com/folke/lazy.nvim for the inspiration!

* ci: fix template formatting

* chore: update editorconfig

* fix: decouple more backgrounds from floats

* change `@tag.attribute` to iris

* add cursor highlights

Closes #121

* match link underline colour

* improve `dim_nc_background` behaviour

ref #123

* feat: expose each variant as individual theme

ref #98

* feat: update tokens

ref #107

* feat: distinguish between `CmpItemKind`'s
@briandipalma
Copy link
Contributor

Thanks, this change seems to have fixed the flickering from dark them to dawn when launching Neovim and the gitcommit messages are now also in dawn, for some reason before they were in dark which was jarring!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge canary rose-pine/neovim
3 participants
@lukepighetti @mvllow @briandipalma