bug: Rosé Pine Dawn hard to read diffview.nvim history view

[briandipalma]

Using https://github.com/sindrets/diffview.nvim and Rosé Pine Dawn is a bit awkward on the eye. I've tested this in Kitty and another terminal so I think it's the theme:

The yellow, the bold cyan and the white text are hard to read. Is there anything that can be done to improve this?

[mvllow]

Hmm, unable to reproduce this. Do you have a minimal config to replicate this?

Example repro:

-- DO NOT change the paths and do not remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- Set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- Bootstrap lazy.nvim
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- Install plugins
local plugins = {
  "rose-pine/neovim.nvim",
  config = function()
    -- Add relevant Rosé Pine config below
    require("rose-pine").setup({})
  end,
  "sindrets/diffview.nvim",
  config = true
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("rose-pine")
-- Add anything else here

Here's my setup using Neovim nightly + Kitty and no plugin config:

Diffview

Diffview file history

[briandipalma]

Yeah looks great with nothing installed:

-- DO NOT change the paths and do not remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- Set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- Bootstrap lazy.nvim
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- Install plugins
local plugins = {
  "rose-pine/neovim",
  config = function()
    -- Add relevant Rosé Pine config below
    require("rose-pine").setup({})
  end,
  "sindrets/diffview.nvim",
  config = true,
  'nvim-lua/plenary.nvim',
  'nvim-tree/nvim-web-devicons'
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("rose-pine")
-- Add anything else here

How does it select the Dawn variant? Is it the default?

[briandipalma]

OK I found the issue, I had

vim.cmd("set background=light")

in my rose-pine config which seemed to cause the problem.
I added

Variant respects vim.o.background, using dawn when light and dark_variant when dark

to the README which no longer seems to be the case, will I rephrase it or delete it?

[briandipalma]

OK, the only issue is the dark variant quickly flashes when I start neovim before changing to the Dawn variant...so I guess the light background setting did do one useful thing. Is there any way I can pass in a configuration setting to enable Dawn from start? I'm guessing at the moment the variant is changed because the theme somehow knows my terminal has a light colour theme selected?

[mvllow]

We may implement separate themes for each variant, e.g. :colorscheme rose-pine-dawn; follow our canary branch to track any progress or subscribe to #98.

At the moment, early in your vim config, set vim.opt.background = "light" to hopefully prevent any flicker :)

[mvllow]

Also, if you are using lazy.nvim, try adding a few options to make Rosé Pine a higher priority:

{
"rose-pine/neovim",
name = "rose-pine",
-- Disable lazy loading
lazy = false,
-- Increase priority
priority = 1000,
config = function()
	require("rose-pine").setup()
	vim.cmd.colorscheme("rose-pine")
end,
},

I will add this to the readme as well.

[briandipalma]

I've subscribed to #98.

At the moment, early in your vim config, set vim.opt.background = "light"

That causes this issue, even when added early in my config. I can live with a flicker.
Without that config though the gitcommit message panel is dark though.

Which is really quite odd.