Pass initial parameter values to node constructor#272
Merged
Conversation
sloretz
force-pushed
the
init_params_via_constructor
branch
from
327c155 to
9ae76ca
Compare
sloretz
added
in review
Member
|
as this and connected PRs were approved before the renaming of "initial_values" to "initial_parameters". Maybe we should apply the same variable renaming to all the connected PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to be targeted at master after #271 is merged.Targeted at masterconnects to ros2/rclcpp#486