use nightly image including all 3 RMWs#215
Merged
mikaelarguedas merged 2 commits intoros2:masterfrom May 15, 2020
Merged
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
ruffsl
approved these changes
May 15, 2020
kyrofa
approved these changes
May 15, 2020
Member
kyrofa
left a comment
There was a problem hiding this comment.
Seems sensible, although would you mind adding a "this doesn't include connext security plugins" as a comment in the YAML so we don't lose that tidbit?
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 77.95% 77.95%
=======================================
Files 16 16
Lines 576 576
Branches 52 52
=======================================
Hits 449 449
Misses 107 107
Partials 20 20
Continue to review full report at Codecov.
|
…er images Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Member
Author
Sure thing, added it in f752a73 for both jobs |
Member
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will unlock PRs adding tests for multiple RMW implementations such as #214
For now no test expect security DDS plugins to be installed. If that becomes the case we would need to either blacklist connext or find a way for the tests to fetch a license with security support and install the security plugins.