permission signing should use permissions_ca#204
Merged
mikaelarguedas merged 1 commit intoros2:masterfrom May 1, 2020
Merged
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
ruffsl
approved these changes
May 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 77.48% 77.52% +0.03%
==========================================
Files 16 16
Lines 573 574 +1
Branches 53 53
==========================================
+ Hits 444 445 +1
Misses 109 109
Partials 20 20
Continue to review full report at Codecov.
|
Member
Author
|
nightly failure expected as ros2/ros2cli#501 hasn't made it into a nightly archive yet |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it worked until now because we're currently using the same ca for identity and permission signing and just symlink it.
This refers to the file names explicitly for the case they are not actual different CAs