Skip to content

Fix: Missing dependency that causes cmake error in downstream (resolves https://github.com/ros2/rosidl_python/issues/198) #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clalancette merged 3 commits into from
Aug 4, 2023
Merged

Fix: Missing dependency that causes cmake error in downstream (resolves https://github.com/ros2/rosidl_python/issues/198) #199

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad6769f
Fix: Missing dependency that causes cmake error in downstream (resolv…
130s Jul 14, 2023
79ffe33
Improve: Move the missing deps to test_depend (response to review com…
130s Jul 18, 2023
195a618
Reviewer's suggestion applied to rosidl_generator_py/package.xml
130s Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions rosidl_generator_py/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,16 @@
<buildtool_export_depend>rosidl_typesupport_c</buildtool_export_depend>
<buildtool_export_depend>rosidl_typesupport_interface</buildtool_export_depend>

<!-- BEGIN: Following 'exec_depend's are likely only needed in test in downstream,
so ideally "test_export_depend" (similar to 'build_export_depend') are reasonable.
With such a feature unexistent yet, they are 'exec_depend'-ed.
See https://github.com/ros2/rosidl_python/pull/199 -->
<exec_depend>ament_cmake_cppcheck</exec_depend>
<exec_depend>ament_cmake_cpplint</exec_depend>
<exec_depend>ament_cmake_flake8</exec_depend>
<exec_depend>ament_cmake_pep257</exec_depend>
Comment thread
130s marked this conversation as resolved.
Comment thread
clalancette marked this conversation as resolved.
<exec_depend>ament_cmake_uncrustify</exec_depend>
<!-- END -->
Comment thread
130s marked this conversation as resolved.
Outdated
<exec_depend>ament_index_python</exec_depend>
<exec_depend>python3-numpy</exec_depend>
<exec_depend>rosidl_cli</exec_depend>
Expand Down