Fix: Missing dependency that causes cmake error in downstream (resolves https://github.com/ros2/rosidl_python/issues/198)#199
Conversation
|
Please add signature to your commit |
|
@quarkytale Thanks, done. |
ros2#198) Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
…ment ros2#199 (comment)) Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
rosidl_generator_py/package.xml
Outdated
| <exec_depend>rpyutils</exec_depend> | ||
|
|
||
| <test_depend>ament_cmake_flake8</test_depend> | ||
| <test_depend>ament_cmake_pep257</test_depend> |
There was a problem hiding this comment.
Ah, oops I wasn't requesting any changes. I think you were correct at first that these need to be exec_depend to make sure downstream message packages depend on them.
I was only commenting to say the current package.xml depend declarations don't cover this case. We would need to create one, probably called test_export_depend, to support it better.
There was a problem hiding this comment.
Got it, reverted.
Adding them as
exec_dependmeans that they'll always be installed when a message package is installed, but these dependencies are probably light enough that this is fine.
It's a bit surprising no one (especially from those who are making products) has requested test_export_depend-like functionality. I can think of huge test_depend-ed packages in an upstream package.
…ment ros2#199 (comment)) Signed-off-by: Isaac Saito <130s@2000.jukuin.keio.ac.jp>
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Minor change to the comment here, then I'm happy with this.
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
|
CI:
|
4 participants
Issue aimed at
ament_cmake_flake8? #198Changes
package.xml.ament_cmake_flake8? #198 (comment), it makes more sense to me in the upstream (here) to install it than making it a job for downstream pkgs.