Skip to content
This repository was archived by the owner on Jan 11, 2019. It is now read-only.

remove cv_bridge and downstream as they dont compile#259

Merged
mikaelarguedas merged 1 commit intoros2from
remove_cv_bridge
Aug 13, 2018
Merged

remove cv_bridge and downstream as they dont compile#259
mikaelarguedas merged 1 commit intoros2from
remove_cv_bridge

Conversation

@mikaelarguedas
Copy link
Copy Markdown
Member

Follow-up of #257

Remove cv_bridge, opencv_tests and vision_opencv as they currently fail to build.

@gaoethan FYI

@mikaelarguedas mikaelarguedas merged commit de62a9a into ros2 Aug 13, 2018
@mikaelarguedas mikaelarguedas deleted the remove_cv_bridge branch August 13, 2018 20:42
@gaoethan
Copy link
Copy Markdown

Sorry, a little confused, I can't reproduce the issue of "opencv not found" within my environment, so I'd like to check what the version of the opencv is installed in yours ? thanks !

@mikaelarguedas
Copy link
Copy Markdown
Member Author

cv_bridge uses OpenCV but doesn't have a dependency on opencv in it's package.xml. So the package cannot be built as it fails to find_package(OpenCV) at https://github.com/ros-perception/vision_opencv/blob/4c6b4c0c6c00b4c47f493e49e2e0c5d0c32d937d/cv_bridge/CMakeLists.txt#L27.

You can reproduce it by doing the following:

$ docker run -it --rm ubuntu:bionic
apt update && apt upgrade -y && apt install -y dirmngr lsb-release gnupg2
history
apt-key adv --keyserver hkp://ha.pool.sks-keyservers.net:80 --recv-key 421C365BD9FF1F717815A3895523BAEEB01FA116
echo "deb [arch=amd64,arm64] http://repo.ros2.org/ubuntu/testing `lsb_release -cs` main" > /etc/apt/sources.list.d/ros2-latest.list
apt update
apt install -y git python3-rosdep python3-colcon-common-extensions
mkdir -p ~/vision_opencv_ws/src && cd ~/vision_opencv_ws/src
git clone https://github.com/ros2-gbp/vision_opencv-release -b debian/bouncy/bionic/cv_bridge
ls
cd ..
export ROSDISTRO_INDEX_URL='https://raw.githubusercontent.com/ros2/rosdistro/ros2/index.yaml'
rosdep init && rosdep update
rosdep install --from-paths src --ignore-src --rosdistro bouncy -y
source /opt/ros/bouncy/setup.bash 
colcon build

@gaoethan
Copy link
Copy Markdown

okay, thanks, there is a follow-up PR ros-perception/vision_opencv#240 verified to address it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants