Skip to content
This repository was archived by the owner on Jan 11, 2019. It is now read-only.

vision_opencv: 2.0.3-0 in 'bouncy/distribution.yaml' [bloom]#257

Merged
mikaelarguedas merged 1 commit intoros2:ros2from
gaoethan:bloom-vision_opencv-0
Aug 7, 2018
Merged

vision_opencv: 2.0.3-0 in 'bouncy/distribution.yaml' [bloom]#257
mikaelarguedas merged 1 commit intoros2:ros2from
gaoethan:bloom-vision_opencv-0

Conversation

@gaoethan
Copy link
Copy Markdown

@gaoethan gaoethan commented Aug 7, 2018

Increasing version of package(s) in repository vision_opencv to 2.0.3-0:

cv_bridge

* fix the build warning with colcon building
* optimize buffer type of imgmsg_to_cv2()
* add python3_opencv and python3_numpy as dependency
* uncrustify 0.67 coding style alignment
* Contributors: Mikael Arguedas, Lars Berscheid, Ethan Gao

image_geometry

  • No changes

opencv_tests

* set zip_safe to avoid warning during installation
* migrate launch to launch.legacy
* fix exception of running launch after sourcing opencv_tests
* Contributors: Ethan Gao

vision_opencv

  • No changes

@mikaelarguedas
Copy link
Copy Markdown
Member

mikaelarguedas commented Aug 7, 2018

lgtm,

Did you get any chance improving the cv_bridge tests ? they are still hanging on my machine so this will likely cause hangs or at least multiple-minute slow down on the builds (I'm going to merge this as is regardless but it would be great to fix the tests in the next version)

@mikaelarguedas mikaelarguedas merged commit f2d3943 into ros2:ros2 Aug 7, 2018
@mikaelarguedas
Copy link
Copy Markdown
Member

@gaoethan we usually don't release test packages as debians as they are not meant to be used by other packages but only for testing.

You can use a bouncy.ignore file in the release repository to skip this package when releasing

@mikaelarguedas
Copy link
Copy Markdown
Member

cv_bridge fails to build because it is missing a dependency on opencv: http://build.ros2.org/view/Bbin_uB64/job/Bbin_uB64__cv_bridge__ubuntu_bionic_amd64__binary/1/console

python_bindings.py test is failing because it depends on nose but doesn't declare a dependency on it.
It should either be converted to pytest (or unittest) or a test dependency on python3-nose should be added

@dirk-thomas
Copy link
Copy Markdown
Member

The nose function assert_equal in question can be replaced with a plain assert. No need to depend on pytest / unittest / nose for that, e.g. assert x == y.

@gaoethan
Copy link
Copy Markdown
Author

gaoethan commented Aug 8, 2018

okay. thanks for your comments and I'll optimize accordingly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants