Delete obsolete compression_options.cpp from rosbag2_cpp#1078
Merged
MichaelOrlov merged 1 commit intorollingfrom Sep 14, 2022
Merged
Delete obsolete compression_options.cpp from rosbag2_cpp#1078MichaelOrlov merged 1 commit intorollingfrom
MichaelOrlov merged 1 commit intorollingfrom
Conversation
compression_options.cpp was supposed to be moved to the `rosbag2_compression` package in #257 but was forgotten to delete from `rosbag2_cpp` package. Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
requested review from
gbiggs and
hidmic
and removed request for
a team
emersonknapp
approved these changes
Sep 7, 2022
Contributor
Author
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/201735aaef5920823af8bfa03834ca97/raw/68fc92afd56106dda438b8e3ac5b74902892dc5e/ros2.repos
|
Contributor
Author
|
New warning on Windows build is a known issue and has already been fixed. |
delete-merged-branch
bot
deleted the
morlov/remove-obsolete-copression_options
branch
Contributor
|
Should this be backported? I just spent a few minutes searching for the compression options header in humble. |
Collaborator
|
@Mergifyio backport humble |
✅ Backports have been createdDetails
|
emersonknapp
pushed a commit
that referenced
this pull request
Mar 11, 2023
compression_options.cpp was supposed to be moved to the `rosbag2_compression` package in #257 but was forgotten to delete from `rosbag2_cpp` package. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit 50e28cb) Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1071
compression_options.cppwas supposed to be moved to therosbag2_compressionpackage in #257 but was forgotten to delete fromrosbag2_cpppackage. Deleting it now to avoid confusion.Signed-off-by: Michael Orlov michael.orlov@apex.ai