Skip to content

pass argv to CommandExtension.add_arguments if available #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dirk-thomas merged 1 commit into from
Jan 23, 2020
Merged

pass argv to CommandExtension.add_arguments if available #437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ros2cli/ros2cli/command/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
# limitations under the License.

import argparse
import inspect
import types

from ros2cli.entry_points import get_entry_points
Expand Down Expand Up @@ -44,7 +45,7 @@ def __init__(self):
super(CommandExtension, self).__init__()
satisfies_version(PLUGIN_SYSTEM_VERSION, '^0.1')

def add_arguments(self, parser, cli_name):
def add_arguments(self, parser, cli_name, *, argv=None):
pass

def main(self, *, parser, args):
Expand Down Expand Up @@ -232,8 +233,13 @@ def add_subparsers_on_demand(
if hasattr(extension, 'add_arguments'):
command_parser = command_parsers[name]
command_parser._root_parser = root_parser
signature = inspect.signature(extension.add_arguments)
kwargs = {}
if 'argv' in signature.parameters:
kwargs['argv'] = argv
extension.add_arguments(
command_parser, '{cli_name} {name}'.format_map(locals()))
command_parser, '{cli_name} {name}'.format_map(locals()),
**kwargs)
del command_parser._root_parser

return subparser
Expand Down