Skip to content

Commit

Permalink
address pr comments
Browse files Browse the repository at this point in the history
Signed-off-by: Brian Chen <[email protected]>
  • Loading branch information
ihasdapie committed Aug 26, 2022
1 parent b037bc5 commit d5d5010
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ros2param/ros2param/verb/set.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ class RequireParameterPairAction(argparse.Action):
def __call__(self, parser, args, values, option_string=None):
if len(values) == 0:
parser.error('No parameters specified')
SystemExit(2)
if len(values) % 2:
parser.error('Must provide parameter name and value pairs')
setattr(args, self.dest, values)
Expand All @@ -61,21 +60,18 @@ def add_arguments(self, parser, cli_name): # noqa: D102

def build_parameters(self, params):
parameters = []

for i in range(0, len(params), 2):
parameter = Parameter()
parameter.name = params[i]
parameter.value = get_parameter_value(string_value=params[i+1])
parameters.append(parameter)

return parameters

def main(self, *, args): # noqa: D102
with NodeStrategy(args) as node:
node_names = get_node_names(
node=node, include_hidden_nodes=args.include_hidden_nodes)
node_name = get_absolute_node_name(args.node_name)

if node_name not in {n.full_name for n in node_names}:
return 'Node not found'

Expand Down

0 comments on commit d5d5010

Please sign in to comment.