Merged
Conversation
It turns out that in the older version of lttng-ust on RHEL-9, the API to set a marker is spelled _lttng_ust_tracef. Include the correct version header file, and use the correct API called depending on what version we are using. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Chris Lalancette <clalancette@gmail.com>
fujitatomoya
approved these changes
Mar 20, 2024
Contributor
Author
|
CI:
|
Member
|
Something weird is happening with GitHub when cloning the repositories in both ci.ros2.org and local GitHub CI. Thanks for fixing this while I'm away from my (real) keyboard, Chris! |
christophebedard
approved these changes
Mar 20, 2024
Member
There was a problem hiding this comment.
Looks good to me with green CI.
I just noticed that I used lttng_ust__tracef instead of what the documentation mentions, lttng_ust_tracef https://lttng.org/docs/v2.13/#doc-tracef. Not sure why; it wasn't really intentional. The difference is that it bypasses the condition that checks if the tracepoint is enabled, so it's pretty minor, but I'll follow up next week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that in the older version of lttng-ust on RHEL-9, the API to set a marker is spelled _lttng_ust_tracef. Include the correct version header file, and use the correct API called depending on what version we are using.
This is a follow-up to the recently merged #96 , where I forgot to run RHEL CI before merging.