Fix interference between test_tracetools and ros2lifecycle tests#96
Merged
christophebedard merged 1 commit intorollingfrom Mar 14, 2024
Conversation
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
clalancette
approved these changes
Mar 14, 2024
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me.
For CI, I think it might make sense to run CI tests both sequential and parallel, though I'll leave it up to you.
Member
Author
|
Yeah I can do that. Tracing tests might fail in parallel without #95, but this particular test should pass. |
Member
Author
Member
Author
|
Those test failures are "expected" (see #95) and not related to this PR. |
Member
Author
|
Alright, CI results are acceptable, I'll merge this and rebase #95. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #94
Relates to #95, but is still separate
test_tracetools'stest_lifecycle_nodetest andros2lifecycle'stest_clitest can interfere with each other if run in parallel, making one of them -- or both of them -- fail. For example,test_tracetoolsfails in this nightly job here: https://ci.ros2.org/view/nightly/job/nightly_linux_debug/2988/.This is mainly because both tests use a lifecycle node with the same name and without any specific namespace:
test_tracetools'stest_lifecycle_nodetest usestest_lifecycle_noderos2lifecycle'stest_clitest usesros2lifecycle_test_fixtures'ssimple_lifecycle_node, which is namedtest_lifecycle_nodeThis can lead to two separate failures:
test_tracetools'stest_lifecycle_nodetest timing out because the state machine ends up in a weird state (not sure why the timeouts intest_lifecycle_node.cppdon't make it exit before the 60-second timeout, though)test_tracetools'stest_lifecycle_nodetest collects can include transitions fromros2lifecycleThe two separate solutions are:
/test_tracetools) for the node intest_tracetools'stest_lifecycle_nodetest to avoid transition/topic-level interference