Mention new logging configuration#882
Merged
clalancette merged 3 commits intoros2:masterfrom Oct 6, 2020
Merged
Conversation
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Member
Author
|
Note that I haven't tested the Windows & MacOS commands (but I'm assuming that the latter is fine). |
ivanpauno
approved these changes
Sep 30, 2020
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
Thanks for documenting the feature.
Your description is really clear!
jacobperron
reviewed
Oct 1, 2020
| To start with you will only see output from log calls with severity ``INFO`` and above (``WARN``, ``ERROR``, ``FATAL``). | ||
| Note that the first message will only be logged once, though the line is reached on each iteration, as that is a property of the log call used for that message. | ||
|
|
||
| Logging directory configuration |
Member
There was a problem hiding this comment.
It's probably worth mentioning here that this feature is only available since Galactic, since this tutorial is generically applying to all distros. (cc/ @maryaB-osr does that sound right?)
Member
Author
There was a problem hiding this comment.
Good point. I added a note in 7c686c7, but if there's a better way let me know.
Contributor
There was a problem hiding this comment.
I think the note is reasonable enough for now. We are working on versioning things better in this repository, but we can go with this until then.
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
clalancette
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a section about the new logging directory configuration feature to the "Logging and logger configuration" tutorial, and also adds it to the list of new features for Galactic.
Relates to ros2/rcl_logging#53
Relates to ros2/launch#460