Allow configuring logging directory through environment variables#460
Merged
ivanpauno merged 10 commits intoros2:masterfrom Oct 13, 2020
Merged
Conversation
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
force-pushed
the
allow-configuring-logging-dir-through-env-vars
branch
from
3eae739 to
bfdcc71
Compare
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Member
Author
|
Switched to |
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
ivanpauno
approved these changes
Sep 30, 2020
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
ivanpauno
reviewed
Sep 30, 2020
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Member
Author
|
CI from ros2/rcl_logging#53 including that PR and this one:
|
|
This one looks ready to go :) |
ivanpauno
approved these changes
Oct 13, 2020
Member
|
Thanks for the contribution @christophebedard ! |
christophebedard
deleted the
allow-configuring-logging-dir-through-env-vars
branch
|
Will this PR be merged into Foxy? |
|
Looks like a safe backport. @ivanpauno would you mind? |
Member
|
If we backport this one, we should also backport ros2/rcl_logging#53 for consistency. @tgreier feel free to open PRs proposing the addition to Foxy. |
Member
|
Bumping to Foxy patch release 5, since no one has gotten to this yet. |
tgreier
added a commit
to tgreier/launch
that referenced
this pull request
Dec 21, 2020
tgreier
added a commit
to tgreier/launch
that referenced
this pull request
Dec 21, 2020
Signed-off-by: tgreier <tgreier@moog.com>
tgreier
pushed a commit
to tgreier/launch
that referenced
this pull request
Dec 22, 2020
…s2#460) Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
hidmic
pushed a commit
that referenced
this pull request
Dec 22, 2020
…) (#477) Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows configuring the logging directory through environment variables using the following logic:
Includes a test.
Perhaps this logic should be moved to
launch_rosin the future.Relates to ros2/rcl_logging#50
See also ros2/rcl_logging#53