removed defaults, proper warnings come up

[BrandonSimoncic]

Description

Removed unnecessary defaults prohibiting compiler warnings.

[fujitatomoya]

overall looks good to me.

default case can be only removed if,

• switch statement manages the enum data type.
• all the variables of enum types are handled in the switch statement.

this is because that the compiler can give us the warning if it is missing the check for any values of enum.

there are several warnings https://build.ros2.org/job/Rpr__rmw_cyclonedds__ubuntu_noble_amd64/49/, can you also take a look at them?

[BrandonSimoncic]

@fujitatomoya Good for review. Last Warning that exists is a deprecated warning coming from one of the enums RMW_QOS_POLICY_LIVELINESS_MANUAL_BY_NODE on line 2275. Not really sure how and where to remove this, if I can get a direction I can add it to the PR!

[fujitatomoya]

Pulls: #549
Gist: https://gist.githubusercontent.com/fujitatomoya/45f6fecf17c9602d360f148355b18e35/raw/3a1863ce7daa5f0b35999df26e150be309a336e6/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_cyclonedds_cpp
TEST args: --packages-above rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17929

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[BrandonSimoncic]

Pulls: #549 Gist: https://gist.githubusercontent.com/fujitatomoya/45f6fecf17c9602d360f148355b18e35/raw/3a1863ce7daa5f0b35999df26e150be309a336e6/ros2.repos BUILD args: --packages-above-and-dependencies rmw_cyclonedds_cpp TEST args: --packages-above rmw_cyclonedds_cpp ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17929

* Linux [![Build Status](https://camo.githubusercontent.com/b96a8059ea8ea19c9af6b35444ddf2c4a2a492efb310c5ae76ada30af46d1af2/687474703a2f2f63692e726f73322e6f72672f6275696c645374617475732f69636f6e3f6a6f623d63695f6c696e7578266275696c643d3236393134)](http://ci.ros2.org/job/ci_linux/26914/)

* Linux-aarch64 [![Build Status](https://camo.githubusercontent.com/9a3766a9c9d4f5ef32a3dff111478758748d18a3f66913c27633122dbfe9fd29/687474703a2f2f63692e726f73322e6f72672f6275696c645374617475732f69636f6e3f6a6f623d63695f6c696e75782d61617263683634266275696c643d3230343331)](http://ci.ros2.org/job/ci_linux-aarch64/20431/)

* Linux-rhel [![Build Status](https://camo.githubusercontent.com/db756b423c156fe187ffaa3abdb19abea09dfa80fbab7683182b83f7e21f28fb/687474703a2f2f63692e726f73322e6f72672f6275696c645374617475732f69636f6e3f6a6f623d63695f6c696e75782d7268656c266275696c643d36363637)](http://ci.ros2.org/job/ci_linux-rhel/6667/)

* Windows [![Build Status](https://camo.githubusercontent.com/245aff4cb04b1e59fb845b9c9fa0965dbf2d67e4c8e4c241505ad778aa18b483/687474703a2f2f63692e726f73322e6f72672f6275696c645374617475732f69636f6e3f6a6f623d63695f77696e646f7773266275696c643d3236333839)](http://ci.ros2.org/job/ci_windows/26389/)

I just removed RMW_QOS_POLICY_LIVELINESS_MANUAL_BY_NODE altogether because it was failing said builds.

[ahcorde]

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[BrandonSimoncic]

It looks like some-kind of Jenkins plugin is failing on these builds.